From a81e9e203d2e579326f6a150d48b6cae026105df Mon Sep 17 00:00:00 2001
From: austin <austin@austinhoover.net>
Date: Tue, 29 Apr 2025 13:11:54 -0400
Subject: [PATCH] edit block performance fix

---
 assets/Data/fab/disjointedroom1.block         | Bin 0 -> 402 bytes
 docs/src/progress/renderertodo.md             |   2 ++
 .../ui/components/FabSelectionPanel.java      |   1 +
 .../gridded/GriddedDataCellManager.java       |  24 +++++++++++++++++-
 4 files changed, 26 insertions(+), 1 deletion(-)
 create mode 100644 assets/Data/fab/disjointedroom1.block

diff --git a/assets/Data/fab/disjointedroom1.block b/assets/Data/fab/disjointedroom1.block
new file mode 100644
index 0000000000000000000000000000000000000000..cec50c81a41cd76f562afa71b3cffec9d8de612c
GIT binary patch
literal 402
zcmV;D0d4*tiwFP!00000|LxkrPJ=)c1<;8THhzE~@YW4!8c{R5#x!n>i>fQ*f>^f3
zAPZZ<zbk?%p)K=@AaC#<($c24G|UA84N9pKrPSHi<FuUj#j8y9ce`0#PTtNtnOXk2
z0rc;fEpN=({&<$D?Na%)V_Ec8u#eexX%e#bb^D9GcWk}sJ+HdW+SiS{_i{%1P-fWP
z@*KA}URL*><@Q$HL-&uR+r4p*JDQc%VzMsw#>HFywl_Onc^)>4-j3-_PS)O=?X#wg
z3%wO2Tm!VbUT7Nkw%qB>-R$^!`ybGoo5t3gtfSd***0A1O~RQ**Z*SvW{lBWKUwrv
zkkAEs`}u7?30-vAo6F~Z63z*R%1Z65zCAT<U-i2=n(pq9k>#)3AyRvTX6Ow700000
z000000000000000U<6VM<0yP5^ORDuev8P^a&i4Izq@(7oiAxZarBbhCt;kBN$G>k
wg&$04O=g<UH)PKJ%OERai`P{dy7H&rp;<oP<X@TvS@xWL0{d2yk{(O|07l)=HUIzs

literal 0
HcmV?d00001

diff --git a/docs/src/progress/renderertodo.md b/docs/src/progress/renderertodo.md
index b721a044..0ed5cfcd 100644
--- a/docs/src/progress/renderertodo.md
+++ b/docs/src/progress/renderertodo.md
@@ -1583,6 +1583,8 @@ Grid alignment actually aligns entity to grid
 Fix door tree physics
 BlockFab metadata
 Structure editing tab in editor view
+Reduce physics generation calls on GriddedDataCellManager
+Fab selection doesn't overflow anymore
 
 
 
diff --git a/src/main/java/electrosphere/client/ui/components/FabSelectionPanel.java b/src/main/java/electrosphere/client/ui/components/FabSelectionPanel.java
index c2a6065b..af01bc7b 100644
--- a/src/main/java/electrosphere/client/ui/components/FabSelectionPanel.java
+++ b/src/main/java/electrosphere/client/ui/components/FabSelectionPanel.java
@@ -132,6 +132,7 @@ public class FabSelectionPanel {
                 newButton.setMarginTop(MARGIN_EACH_SIDE);
                 //label
                 Label fabLabel = Label.createLabel(fabFile.getName());
+                fabLabel.setMaxWidth(FAB_BUTTON_WIDTH);
                 //icon/model
                 ImagePanel texturePanel = ImagePanel.createImagePanel(AssetDataStrings.TEXTURE_DEFAULT);
                 texturePanel.setWidth(FAB_BUTTON_TEXTURE_DIM);
diff --git a/src/main/java/electrosphere/server/datacell/gridded/GriddedDataCellManager.java b/src/main/java/electrosphere/server/datacell/gridded/GriddedDataCellManager.java
index bea63049..9794c9c3 100644
--- a/src/main/java/electrosphere/server/datacell/gridded/GriddedDataCellManager.java
+++ b/src/main/java/electrosphere/server/datacell/gridded/GriddedDataCellManager.java
@@ -151,6 +151,11 @@ public class GriddedDataCellManager implements DataCellManager, VoxelCellManager
      * Number of data cells cleaned up in the most recent frame
      */
     int numCleaned = 0;
+
+    /**
+     * Queue of cells that need to have their physics regenerated (ie on block edits)
+     */
+    Map<Long,Vector3i> physicsQueue = new HashMap<Long,Vector3i>();
     
     /**
      * Constructor
@@ -658,6 +663,20 @@ public class GriddedDataCellManager implements DataCellManager, VoxelCellManager
     public void simulate(){
         Globals.profiler.beginCpuSample("GriddedDataCellManager.simulate");
         loadedCellsLock.lock();
+
+
+        //regenerate physics where relevant
+        terrainEditLock.acquireUninterruptibly();
+        if(physicsQueue.size() > 0){
+            for(Vector3i pos : physicsQueue.values()){
+                this.createTerrainPhysicsEntities(pos);
+            }
+            physicsQueue.clear();
+        }
+        terrainEditLock.release();
+
+
+        //micro simulation
         boolean runMicroSim = Globals.microSimulation != null && Globals.microSimulation.isReady();
         for(ServerDataCell cell : this.groundDataCells.values()){
             if(runMicroSim && this.shouldSimulate(cell)){
@@ -1041,7 +1060,10 @@ public class GriddedDataCellManager implements DataCellManager, VoxelCellManager
             ServerDataCell cell = groundDataCells.get(this.getServerDataCellKey(worldPosition));
             if(cell != null){
                 //update physics
-                this.createTerrainPhysicsEntities(worldPosition);
+                long key = this.getServerDataCellKey(worldPosition);
+                if(!this.physicsQueue.containsKey(key)){
+                    this.physicsQueue.put(key,worldPosition);
+                }
 
                 //broadcast update
                 cell.broadcastNetworkMessage(TerrainMessage.constructUpdateBlockMessage(